Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masked Relation Classifier #2748

Merged
merged 70 commits into from
Nov 6, 2022
Merged

Masked Relation Classifier #2748

merged 70 commits into from
Nov 6, 2022

Commits on Apr 8, 2022

  1. Implement masked relation classifier encoder

    @dobbersc
    dobbersc committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    3c36283 View commit details
    Browse the repository at this point in the history

  2. Cleanup imports

    @dobbersc
    dobbersc committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    3a8927d View commit details
    Browse the repository at this point in the history

  3. Improve docstrings

    @dobbersc
    dobbersc committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    73b5fe8 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Rename relation argument entity to span

    @dobbersc
    dobbersc committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    b249d32 View commit details
    Browse the repository at this point in the history

  2. - Return original sentence relations with masked sentences 

    - Correct docstring relation direction
    @dobbersc
    dobbersc committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    cc8bf71 View commit details
    Browse the repository at this point in the history

  3. Implement relation classifier forward pass

    @dobbersc
    dobbersc committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    8143656 View commit details
    Browse the repository at this point in the history

  4. Inherit from DefaultClassifier instead of TextClassifier

    @dobbersc
    dobbersc committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    f5d3057 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Skip input sentences with no entity pairs

    @dobbersc
    dobbersc committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    d1da856 View commit details
    Browse the repository at this point in the history

  2. Implement state dict getter and init

    @dobbersc
    dobbersc committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    fbb5b78 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Use relation.unlabeled_identifier instead of a custom unique positi… 

    …onal identifier
    @dobbersc
    dobbersc committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    782b7f7 View commit details
    Browse the repository at this point in the history

  2. Implement option to train on gold labels only

    @dobbersc
    dobbersc committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    de6f3f2 View commit details
    Browse the repository at this point in the history

  3. Add __init__ docstring

    @dobbersc
    dobbersc committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    d1fcb36 View commit details
    Browse the repository at this point in the history

  4. Expose RelationClassifier

    @dobbersc
    dobbersc committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    eaa4065 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Remove solved TODOs

    @dobbersc
    dobbersc committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    c46dcac View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. - Add the zero tag value to the label dictionary 

    - Add option do remove the `<unk>` tag from the passed label dictionary
    @dobbersc
    dobbersc committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    2eb6d3f View commit details
    Browse the repository at this point in the history

  2. Remove solved TODO

    @dobbersc
    dobbersc committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    f2657ea View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. Implement option to mask remainder entities

    @dobbersc
    dobbersc committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    a23973b View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Update docstring

    @dobbersc
    dobbersc committed May 1, 2022
    Configuration menu
    Copy the full SHA
    7bd0758 View commit details
    Browse the repository at this point in the history

  2. Add RelationClassifier docstring

    @dobbersc
    dobbersc committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6dcee83 View commit details
    Browse the repository at this point in the history

  3. Fix typehints

    @dobbersc
    dobbersc committed May 1, 2022
    Configuration menu
    Copy the full SHA
    447e3e8 View commit details
    Browse the repository at this point in the history

  4. Reorder imports

    @dobbersc
    dobbersc committed May 1, 2022
    Configuration menu
    Copy the full SHA
    ba4bb87 View commit details
    Browse the repository at this point in the history

  5. Fix forward_pass type-hint to conform with the RelationClassifier

    @dobbersc
    dobbersc committed May 1, 2022
    Configuration menu
    Copy the full SHA
    a99573c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Move old RelationExtractor tests to test_relation_extractor.py

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    96fa2ad View commit details
    Browse the repository at this point in the history

  2. Add test for RelationClassifier

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    5a2bd37 View commit details
    Browse the repository at this point in the history

  3. Refactor valid entity extraction into its own function

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    7564f81 View commit details
    Browse the repository at this point in the history

  4. Implement optional entity confidence filter

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    81302cd View commit details
    Browse the repository at this point in the history

  5. Rename _RelationArgument -> _Entity

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    34f059b View commit details
    Browse the repository at this point in the history

  6. Fix isort

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    177178f View commit details
    Browse the repository at this point in the history

  7. Refactor relations parameter to entity_pair_labels (the concrete … 

    …relation label is now omitted)
    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    84f5da2 View commit details
    Browse the repository at this point in the history

  8. Reduce trained epochs

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    55ee5c4 View commit details
    Browse the repository at this point in the history

  9. Fix flake8 and isort

    @dobbersc
    dobbersc committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c7a1ac5 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Rework RelationClassifier to correctly work with the model trainer'… 

    …s mini-batching and be more memory efficient (cross augmentation is now handled before the training loop)
    @dobbersc
    dobbersc committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    2b99799 View commit details
    Browse the repository at this point in the history

  2. Format with black

    @dobbersc
    dobbersc committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    8511a10 View commit details
    Browse the repository at this point in the history

  3. Remove leftover todo

    @dobbersc
    dobbersc committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    f02d3be View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. - Split sentence encoding into functions for training and inference 

    - Fix some type hints
    @dobbersc
    dobbersc committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    dcb7cdf View commit details
    Browse the repository at this point in the history

  2. Add generic type-hinting to corpus object

    @dobbersc
    dobbersc committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a9f5994 View commit details
    Browse the repository at this point in the history

  3. Add sanity check for encoded sentences with a hopefully helpful error… 

    … message
    @dobbersc
    dobbersc committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    964a4bb View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Fix inherited DefaultClassifier type generic and typing in `self.pr… 

    …edict`
    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    681f112 View commit details
    Browse the repository at this point in the history

  2. Fix mypy complaints

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    d0998ee View commit details
    Browse the repository at this point in the history

  3. Reorder imports

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f7ffdf0 View commit details
    Browse the repository at this point in the history

  4. Adjust tests to the reworked relation classifier

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    86df85d View commit details
    Browse the repository at this point in the history

  5. Format code with black

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    828e0bc View commit details
    Browse the repository at this point in the history

  6. Fix bug where the test dataset is always None when using `transform… 

    …_corpus`
    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    43e9e6f View commit details
    Browse the repository at this point in the history

  7. Make _EncodedSentence public

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7f792f4 View commit details
    Browse the repository at this point in the history

  8. Add tests for sentence transformations

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    3709b9c View commit details
    Browse the repository at this point in the history

  9. For some reason the local tests run through, maybe train for longer?

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    2ee7821 View commit details
    Browse the repository at this point in the history

  10. Remove transform_test parameter from transform_corpus function (M… 

    …ore consistent type hinting and this is not really useful)
    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c85d619 View commit details
    Browse the repository at this point in the history

  11. Use DataLoader to iterator over dataset

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    006cab0 View commit details
    Browse the repository at this point in the history

  12. Increase test train epochs

    @dobbersc
    dobbersc committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c60369a View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Reorder imports

    @dobbersc
    dobbersc committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    434f8e0 View commit details
    Browse the repository at this point in the history

  2. Improve relation classification test dataset

    @dobbersc
    dobbersc committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    52ef1ce View commit details
    Browse the repository at this point in the history

  3. Fix import order

    @dobbersc
    dobbersc committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c5e330c View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Merge branch 'master' into masked-relation-classifier

    @dobbersc
    dobbersc committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    e2a1c2b View commit details
    Browse the repository at this point in the history

  2. Fix allow_unk_tag parameter setting

    @dobbersc
    dobbersc committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0d5610a View commit details
    Browse the repository at this point in the history

  3. Add some docstrings for documentation

    @dobbersc
    dobbersc committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    e208738 View commit details
    Browse the repository at this point in the history

  4. Add some docstrings for documentation

    @dobbersc
    dobbersc committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    3836e4d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Format with black

    @dobbersc
    dobbersc committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a53f4cc View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Formatting

    @dobbersc
    dobbersc committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    44ead22 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Merge branch 'master' into masked-relation-classifier 

    # Conflicts:
#	tests/test_relation_classifier.py
    @dobbersc
    dobbersc committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    887e917 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Merge branch 'master' into masked-relation-classifier

    @alanakbik
    alanakbik authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    634bede View commit details
    Browse the repository at this point in the history

  2. Reintroduce corpus generics

    @dobbersc
    dobbersc committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    78082ad View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Merge branch 'master' into masked-relation-classifier

    @alanakbik
    alanakbik committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    691d1e6 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @alanakbik
    alanakbik committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    1facd3c View commit details
    Browse the repository at this point in the history

  3. Make mypy less unhappy

    @alanakbik
    alanakbik committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    ed16a46 View commit details
    Browse the repository at this point in the history

  4. Make black happy

    @alanakbik
    alanakbik committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    1dce897 View commit details
    Browse the repository at this point in the history

  5. Remove unused import

    @alanakbik
    alanakbik committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    ae55638 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Make mypy happy without type ignores

    @dobbersc
    dobbersc committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    bc81548 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. Change default to non-label aware masking

    @alanakbik
    alanakbik committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    2ebf066 View commit details
    Browse the repository at this point in the history

  2. Make masking configurable

    @alanakbik
    alanakbik committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    36fb037 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. Remove remainder logic and fix unit tests

    @alanakbik
    alanakbik committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    4a85ba1 View commit details
    Browse the repository at this point in the history