Updated token.py for gradient calculations #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved fwd pass to no_grad
|
@vsamarths thanks for improving this! @helpmefindaname can you take a look? (Since you're refactoring the TransformerEmbeddings at the moment ;)) |
|
This looks good, I've added the change to my PR |
|
Great! I'll also merge this to master to recognize the contribution! Thanks a lot @vsamarths! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TransformersWordEmbeddingsforward pass was not put within thegradient_context. Hence the forward pass was not encapsulated within thetorch.no_grad()in casefine_tuning = Falseis set . This fix improves GPU memory management and speed.