Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-revise-http-connector #645

Merged
merged 19 commits into from
Aug 20, 2024
Merged

dev-revise-http-connector #645

merged 19 commits into from
Aug 20, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Aug 12, 2024

  • add primitive rate limiting
  • add timeout option for http generator

closes: #644

@ekneg54 ekneg54 self-assigned this Aug 12, 2024
@ekneg54 ekneg54 changed the title refactor jsonl connector dev-revise-http-connector Aug 12, 2024
@ekneg54 ekneg54 requested a review from djkhl August 14, 2024 18:23
@ekneg54 ekneg54 marked this pull request as ready for review August 14, 2024 18:26
@ekneg54 ekneg54 requested a review from herrfeder August 15, 2024 07:23
@ekneg54 ekneg54 merged commit 1b7cb39 into main Aug 20, 2024
12 checks passed
@ekneg54 ekneg54 deleted the dev-revise-http-connector branch August 20, 2024 09:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (1ef1b78) to head (ff1cc8a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   94.44%   94.50%   +0.05%     
==========================================
  Files         147      147              
  Lines        9926    10001      +75     
==========================================
+ Hits         9375     9451      +76     
+ Misses        551      550       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dead links
3 participants