Graceful stopping of controller #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing a GoPool will prevent any new work from coming in, while waiting for a period for the current workers in the pool to finish.
We used to add all evaluations that are not in the workQueue (invocationController) to the workQueue, even those that are currently being evaluated. This led to potentially a lot of unnecesary evaluations being added to workqueue. This change prevents these from being added, by checking whether the evaluations are locked (== being evaluated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently stopping the controller will not await any of the currently running tasks, even though --- most of the time --- these tasks finish in at most a few seconds.
This change adds a graceful stopping feature to the invocation controller, making it wait for the current tasks to finish before fully stopping the controller and related structures.
As a flyby, this PR...
fnenvpackages to clarify the function of components.