Skip to content

Commit

Permalink
Makefile: do not compile rust/download_web with old toolchain
Browse files Browse the repository at this point in the history
libz-sys crate became incompatible with Alpine 3.13 toolchain (rust 1.47):

    error: unexpected token: `zng_prefix`
       --> /root/.cargo/registry/src/github.51.al-1ecc6299db9ec823/libz-sys-1.1.8/src/lib.rs:115:19
        |
    114 | extern "C" {
        |            - while parsing this item list starting here
    115 |     #[link_name = zng_prefix!(adler32)]
        |                   ^^^^^^^^^^
    ...
    241 | }
        | - the item list ends here

With Alpine 3.14 toolchain (rust 1.52):

    error[E0658]: arbitrary expressions in key-value attributes are unstable
       --> /root/.cargo/registry/src/github.51.al-1ecc6299db9ec823/libz-sys-1.1.8/src/lib.rs:115:19
        |
    115 |     #[link_name = zng_prefix!(adler32)]
        |                   ^^^^^^^^^^^^^^^^^^^^
        |
        = note: see issue #78835 <rust-lang/rust#78835> for more information
  • Loading branch information
fishilico committed May 29, 2022
1 parent 1ceae3a commit 5255c3c
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 11 deletions.
7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,17 @@ else
# note: for more information, see https://github.com/rust-lang/rust/issues/62254
# Old versions of rustc (<=1.44) fail to build socket2-0.4.0 because:
# error[E0658]: `match` is not allowed in a `const fn`
# Fnote: see issue #49146 <https://github.com/rust-lang/rust/issues/49146> for more information
# note: see issue #49146 <https://github.com/rust-lang/rust/issues/49146> for more information
# Old versions of rustc (<=1.44) fail to build clap-2.33.3 because:
# error[E0723]: loops and conditional expressions are not stable in const fn
# note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(3[0-9]\|4[0-4]\)\.'),y)
SUBDIRS_BLACKLIST += rust/asymkeyfind% rust/check_linux_pass% rust/download_web%
else ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(4[5-9]\|5[0-2]\)\.'),y)
# Old versions of rustc (<=1.52) fail to build libz-sys-1.1.8 because:
# error[E0658]: arbitrary expressions in key-value attributes are unstable
# note: see issue #78835 <https://github.com/rust-lang/rust/issues/78835> for more information
SUBDIRS_BLACKLIST += rust/download_web%
endif
endif

Expand Down
2 changes: 1 addition & 1 deletion machines/Dockerfile-alpine3.13
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ COPY . /shared/
CMD ["/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c: x86-read_64b_regs_in_32b_mode
# glossaries:
Expand Down
2 changes: 1 addition & 1 deletion machines/Dockerfile-alpine3.14
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ COPY . /shared/
CMD ["/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c: x86-read_64b_regs_in_32b_mode
# glossaries:
Expand Down
4 changes: 2 additions & 2 deletions machines/Dockerfile-debian11-bullseye
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ COPY . /shared/
CMD ["/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c:
# glossaries:
Expand All @@ -76,7 +76,7 @@ CMD ["/run_shared_test.sh"]
# rust:
# verification:
# With gcc -m32:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c: gmp_functions gtk_alpha_window
# glossaries:
Expand Down
4 changes: 2 additions & 2 deletions machines/Dockerfile-fedora31
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ COPY . /shared/
CMD ["/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c:
# glossaries:
Expand All @@ -79,7 +79,7 @@ CMD ["/run_shared_test.sh"]
# rust:
# verification:
# With gcc -m32:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c: gtk_alpha_window
# glossaries:
Expand Down
4 changes: 2 additions & 2 deletions machines/Dockerfile-fedora32
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ COPY . /shared/
CMD ["xvfb-run", "/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c:
# glossaries:
Expand All @@ -79,7 +79,7 @@ CMD ["xvfb-run", "/run_shared_test.sh"]
# rust:
# verification:
# With gcc -m32:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c: gtk_alpha_window
# glossaries:
Expand Down
4 changes: 2 additions & 2 deletions machines/Dockerfile-ubuntu1604-xenial
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ COPY . /shared/
CMD ["/run_shared_test.sh"]

# make list-nobuild:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c:
# glossaries: check_sort_order.py
Expand All @@ -77,7 +77,7 @@ CMD ["/run_shared_test.sh"]
# rust:
# verification:
# With gcc -m32:
# Global blacklist: latex%
# Global blacklist: latex% rust/download_web%
# In sub-directories:
# c: gmp_functions gtk_alpha_window
# glossaries: check_sort_order.py
Expand Down

0 comments on commit 5255c3c

Please sign in to comment.