Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete branch after merge on Github. #123

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Delete branch after merge on Github. #123

merged 2 commits into from
Aug 18, 2023

Conversation

cptwunderlich
Copy link
Contributor

No description provided.

@cptwunderlich
Copy link
Contributor Author

If the delete call fails, we don't log that and ignore the error. That is not optimal, but I'm not sure whether we want to fail the whole merge action in that case? And logging is not available.

@cptwunderlich cptwunderlich merged commit 9771a33 into master Aug 18, 2023
8 checks passed
@cptwunderlich cptwunderlich deleted the github-delete-branch branch August 18, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomnc brunomnc brunomnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cptwunderlich @brunomnc