Various improvements #140
Open
Various improvements #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem.log and default format for all others.
aadmathijssen
suggested changes
Nov 30, 2021
There was a problem hiding this comment.
Hi @colinmollenhour,
I have reviewed and tested the changes. I only have two minor remarks.
BTW I like the sane defaults in the config.xml. Also escaping the / in the preg_match is a good find!
aadmathijssen
approved these changes
Dec 1, 2021
m-overlund
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aadmathijssen Would you mind taking a look at this PR to get a second set of eyes on?