Update CNI dependencies to v1.0.0 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I'll have to update the same in https://github.com/awslabs/tc-redirect-tap/ as well. |
darkowlzz
changed the title
This was referenced Aug 26, 2021
|
@darkowlzz Can you update CNI Plugins to 1.0.1 which is the official release. The 1.0.0 release was broken. |
gaby
reviewed
Oct 22, 2021
gaby
reviewed
Oct 22, 2021
gaby
suggested changes
Oct 22, 2021
`IPConfig` in v1.0.1 removes the `Version` field. Signed-off-by: Sunny <darkowlzz@protonmail.com>
|
Updated to CNI dependencies to v1.0.1. Thanks @gaby . |
I already submitted 1.0.1 for awslabs/tc-redirect-tap#11 |
gaby
approved these changes
Oct 23, 2021
|
@kzys Friendly bump, this PR is related to awslabs/tc-redirect-tap#11 |
|
@kzys, any news on getting this merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CNI dependencies to v1.0.0.
IPConfigin v1.0.0 removes theVersionfield.In the ignite project, we would like to use CNI v1.0.0, but since ignite uses firecracker-go-sdk, CNI dependencies have to be updated here as well. The change is mostly based on containernetworking/cni#783 . Hope that's okay.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.