Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firebase_app_check, android): update deprecated Tasks.call() to TaskCompletionSource API #9404

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

russellwheatley
Copy link
Member

Description

See title.

Related Issues

As part of #8073

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title chore(database, android): update deprecated Task.call() to TaskCompletionSource API chore(firebase_database, android): update deprecated Task.call() to TaskCompletionSource API Aug 23, 2022
@russellwheatley russellwheatley changed the title chore(firebase_database, android): update deprecated Task.call() to TaskCompletionSource API chore(firebase_app_check, android): update deprecated Task.call() to TaskCompletionSource API Aug 23, 2022
@russellwheatley russellwheatley added platform: android Issues / PRs which are specifically for Android. plugin: app_check type: infrastructure Improvements to the codebase labels Aug 24, 2022
@russellwheatley russellwheatley changed the title chore(firebase_app_check, android): update deprecated Task.call() to TaskCompletionSource API chore(firebase_app_check, android): update deprecated Task.call() to TaskCompletionSource API Aug 24, 2022
@russellwheatley russellwheatley changed the title chore(firebase_app_check, android): update deprecated Task.call() to TaskCompletionSource API chore(firebase_app_check, android): update deprecated Tasks.call() to TaskCompletionSource API Aug 24, 2022
@russellwheatley russellwheatley merged commit 5aa9f66 into master Aug 24, 2022
@russellwheatley russellwheatley deleted the @russell/app-check-8073 branch August 24, 2022 11:28
@firebase firebase locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: android Issues / PRs which are specifically for Android. plugin: app_check type: infrastructure Improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants