-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Public Preview launch branch into master #7703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update cli support for toolkit and webhooks * update ports * update ports * Replace any with Options * update exec to call webhook, format * address comment * address comment * remove unused var --------- Co-authored-by: joehan <joehanley@google.com>
* update cli support for toolkit and webhooks * update ports * update ports * Replace any with Options * update exec to call webhook, format * address comment * address comment * remove unused var * vscode implementation of emulator start * delete debug log * address comments --------- Co-authored-by: joehan <joehanley@google.com>
* Hacking away at pglite+dataconnect emulator * Hacking away at it * More debugging * I THINK IT WORKSSSSS * Saving my progress at EoD * --amend * Progress * clean up * formatting * Use extended query patch (thanks @gregnr!) * Format and merge master * PR fixes * Remove JSON comments * format * Fxing test compilation issues * Cleaning up build issues * PR fixes * Format and generate json schema * Patching in missing types for VSCode builds * More type fixing * More type fixing * Little bit mroe code review * Removed unused dep * More pr fixes * test:emualtors build fixed * PR fixes * Fix port disagreement
* fix webhooks and cleanup old emulator code * await sendVSCode completion
* Clean up extension configuration * pulls out messages into i10n/markdown-compatible source * Simplify the config getter * Remove errant firebase-path
* Add firebase-path option for vscode Allow folks to specify a specific firebase binary * Update vscode port
* cleaning up localconnectionstring * LocalConnectionString is dead * test fix * Good catch
* Rough pass on extension UI * Update docs UI * Flex the panels to get full-width content
Created using spr 1.3.6-beta.1
* Round 1 of bug bash fixes * Fixing build issue * Fix package-lock.json * Oops * Use lsofi instead of rolling our own * format
… emulators start (#7692)
…ate (#7682) * Add handling for port conflicts. Add fallback for emulator loading state * update equality * address comments
#7691) * WIP - better error handlingport conflicts * Void * Update src/emulator/storage/rules/runtime.ts Co-authored-by: Yuchen Shi <yuchenshi@google.com> * Update src/emulator/downloadableEmulators.ts Co-authored-by: Yuchen Shi <yuchenshi@google.com> * Find open ports --------- Co-authored-by: Yuchen Shi <yuchenshi@google.com>
* update emulator reset text * update text
joehan
reviewed
Sep 23, 2024
joehan
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.