Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SDK generation as part of firebase init dataconnect #7693

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Sep 20, 2024

Description

Include firebase init dataconnect:sdk functionality as part of firebase init dataconnect.

Also updated the app directory prompt: "Where is your app directory? Leave blank to set up a generated SDK in your current directory."

Scenarios Tested

  • firebase init dataconnect in a folder with build.gradle
  • firebase init dataconnect in a folder without platform indicators, (y) when prompted for gen SDKs
  • firebase init dataconnect in a folder without platform indicators, (n) when prompted for gen SDKs

Sample Commands

firebase init dataconnect in a folder with build.gradle:
Screenshot 2024-09-23 at 12 40 54 PM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.75%. Comparing base (18e3189) to head (27300d0).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
src/init/features/dataconnect/index.ts 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7693      +/-   ##
==========================================
- Coverage   56.91%   56.75%   -0.17%     
==========================================
  Files         396      396              
  Lines       27599    27726     +127     
  Branches     5692     5737      +45     
==========================================
+ Hits        15708    15735      +27     
- Misses      11723    11822      +99     
- Partials      168      169       +1     
Flag Coverage Δ
56.75% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosalyntan rosalyntan marked this pull request as ready for review September 20, 2024 21:20
@rosalyntan rosalyntan enabled auto-merge (squash) September 23, 2024 20:37
@rosalyntan rosalyntan merged commit cfef5fe into master Sep 23, 2024
40 of 41 checks passed
@rosalyntan rosalyntan deleted the rosalyntan.sdk branch September 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants