Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove authMode #7659

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Remove authMode #7659

merged 3 commits into from
Sep 16, 2024

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Sep 16, 2024

Tested with existing connector.yaml. Works fine with any command.

I think the json schema is only used for VS Code linter.

joehan
joehan approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're correct about the JSON schema only being used by vscode linter plugins

@fredzqm fredzqm enabled auto-merge (squash) September 16, 2024 19:28
@fredzqm fredzqm merged commit 2503dfa into master Sep 16, 2024
39 of 41 checks passed
pr-Mais pushed a commit that referenced this pull request Sep 19, 2024
@fredzqm @pr-Mais
Remove authMode (#7659)
8f3e055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

Assignees

@joehan joehan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredzqm @joehan