Implement schemaValidation mode handling in dataconnect:sql:migrate and deploy
#7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalyntan
changed the title
dataconnect:sql:migrate and deploy
rosalyntan
changed the title
dataconnect:sql:migrate and deployschemaValidation mode handling in dataconnect:sql:migrate and deploy
joehan
reviewed
Sep 16, 2024
| @@ -34,6 +34,7 @@ export const command = new Command("dataconnect:sql:migrate [serviceId]") | |||
| options, | |||
| schema: serviceInfo.schema, | |||
| validateOnly: true, | |||
| schemaValidation: serviceInfo.dataConnectYaml.schema.datasource.postgresql?.schemaValidation, | |||
There was a problem hiding this comment.
Quick sanity check - does this get broken by our move from datasource -> datasources? @fredzqm might know off the top of his head.
There was a problem hiding this comment.
Chatted offline -- based on go/fdc:multi-data-source it looks like the datasource field will still be supported, though we should also support datasources in #7589.
joehan
approved these changes
Sep 16, 2024
pr-Mais
pushed a commit
that referenced
this pull request
Sep 19, 2024
…e` and `deploy` (#7639) * Support handling schema validation options in `diff`. * Format. * Don't output second set of diffs if they're equal to the first. * Update dataconnect:sql:migrate * Fix my failed rebase lol * Finish handling schemaValidation mode in `dataconnect:sql:migrate`. * Fix setSchemaValidationMode. * Concat follow-up strict diffs, instead of replacing compat diffs. * Don't display purely optional changes with flag. * Pass `schemaValidation` into `deploy` command. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
firebase dataconnect:sql:migrateandfirebase deployper go/fdc-compat-mode-cli-api.Scenarios Tested
schemaValidationunset, both required and optional changes:firebase deployfirebase deploy --forcefirebase deploy --non-interactivefirebase deploy --non-interactive --forcefirebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --forcefirebase dataconnect:sql:migrate --non-interactivefirebase dataconnect:sql:migrate --non-interactive --forceschemaValidationunset, only required changes:firebase deployfirebase deploy --forcefirebase deploy --non-interactivefirebase deploy --non-interactive --forcefirebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --forcefirebase dataconnect:sql:migrate --non-interactivefirebase dataconnect:sql:migrate --non-interactive --forceschemaValidationunset, only optional changes:firebase deployfirebase deploy --forcefirebase deploy --non-interactivefirebase deploy --non-interactive --forcefirebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --forcefirebase dataconnect:sql:migrate --non-interactivefirebase dataconnect:sql:migrate --non-interactive --forceschemaValidation=COMPATIBLE, both required and optional changes:firebase deployfirebase deploy --forcefirebase deploy --non-interactivefirebase deploy --non-interactive --forcefirebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --forcefirebase dataconnect:sql:migrate --non-interactivefirebase dataconnect:sql:migrate --non-interactive --forceschemaValidation=COMPATIBLE, only optional changes:firebase deployfirebase deploy --forcefirebase deploy --non-interactivefirebase deploy --non-interactive --forcefirebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --forcefirebase dataconnect:sql:migrate --non-interactivefirebase dataconnect:sql:migrate --non-interactive --forceschemaValidation=STRICT, both required and optional changes:firebase deployfirebase deploy --forcefirebase deploy --non-interactivefirebase deploy --non-interactive --forcefirebase dataconnect:sql:migratefirebase dataconnect:sql:migrate --forcefirebase dataconnect:sql:migrate --non-interactivefirebase dataconnect:sql:migrate --non-interactive --forceSample Commands
firebase deploy, withschemaValidationunset, both required and optional changes, and default options selected: