Add --dry-run to deploy #7574
Merged
Add --dry-run to deploy #7574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalyntan
reviewed
Aug 22, 2024
ifielker
reviewed
Aug 22, 2024
src/deploy/functions/prepare.ts
Outdated
| @@ -276,9 +277,12 @@ export async function prepare( | |||
| // ===Phase 7. Finalize preparation by "fixing" all extraneous environment issues like IAM policies. | |||
| // We limit the scope endpoints being deployed. | |||
| await backend.checkAvailability(context, matchingBackend); | |||
| await ensureServiceAgentRoles(projectId, projectNumber, matchingBackend, haveBackend); | |||
| // TODO: CheckServiceAgentRoles when dryRun = true | |||
There was a problem hiding this comment.
I assume you will do this TODO before you submit this PR?
src/deploy/functions/prepare.ts
Outdated
| await validate.secretsAreValid(projectId, matchingBackend); | ||
| await ensure.secretAccess(projectId, matchingBackend, haveBackend); | ||
| // TODO: CheckSecretAccess when dryRun = true |
milyes
approved these changes
Aug 27, 2024
joehan
commented
Aug 27, 2024
milyes
approved these changes
Aug 27, 2024
milyes
approved these changes
Aug 27, 2024
rosalyntan
approved these changes
Aug 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7574 +/- ##
==========================================
- Coverage 53.06% 52.79% -0.28%
==========================================
Files 391 394 +3
Lines 27003 27525 +522
Branches 5571 5687 +116
==========================================
+ Hits 14330 14532 +202
- Misses 11393 11703 +310
- Partials 1280 1290 +10 ☔ View full report in Codecov by Sentry. |
rosalyntan
reviewed
Sep 12, 2024
| @@ -55,6 +58,36 @@ export default async function (context: any, options: Options): Promise<void> { | |||
| filters, | |||
| }; | |||
| utils.logLabeledBullet("dataconnect", `Successfully prepared schema and connectors`); | |||
| if (options.dryRun) { | |||
There was a problem hiding this comment.
From chatting offline -- we should invoke diffSchema here to surface migration diffs in dryRun
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
--dry-runflag tofirebase deploy.firebase deploy --dry-runwill run any validations or build steps, and then report information about what change would have been made, without making any changes to your project.Under the hood, this means that we only run the prepare step, and skip release/deploy. I reviewed
prepare.tsfor each product to ensure they don't make any production changes, and moved some validation from later stages to prepare where it belongs.