Added dart to firebase CLI

src/commands/dataconnect-sdk-generate.ts

@@ -7,6 +7,7 @@
 import { load } from "../dataconnect/load";
 import { readFirebaseJson } from "../dataconnect/fileUtils";
 import { logger } from "../logger";
+import * as experiments from "../experiments";
 
 export const command = new Command("dataconnect:sdk:generate")
   .description("generates typed SDKs for your Data Connect connectors")
@@ -21,7 +22,8 @@
         return (
           c.connectorYaml.generate?.javascriptSdk ||
           c.connectorYaml.generate?.kotlinSdk ||
-          c.connectorYaml.generate?.swiftSdk
+          c.connectorYaml.generate?.swiftSdk ||
+          c.connectorYaml.generate?.dartSdk
         );
       });
       if (!hasGeneratables) {

src/dataconnect/fileUtils.spec.ts

@@ -85,6 +85,31 @@ describe("getPlatformFromFolder", () => {
       },
       output: Platform.IOS,
     },
+    {
+      desc: "Dart identifier 1",
+      folderName: "is/this/a/dart/test",
+      folderItems: {
+        file1: "contents",
+        "pubspec.yaml": "my deps",
+      },
+      output: Platform.DART,
+    },
+    {
+      desc: "Dart identifier 2",
+      folderName: "is/this/a/dart/test",
+      folderItems: {
+        "pubspec.lock": "my deps",
+      },
+      output: Platform.DART,
+    },
+    {
+      desc: "Dart identifier with experiment disabled",
+      folderName: "is/this/a/dart/test",
+      folderItems: {
+        "pubspec.mispelled": "my deps",
+      },
+      output: Platform.UNDETERMINED,
+    },
     {
       desc: "multiple identifiers, returns undetermined",
       folderName: "test/",
@@ -157,6 +182,19 @@ describe("generateSdkYaml", () => {
     });
   });
 
+  it("should add Dart SDK generation for DART platform", () => {
+    const modifiedYaml = generateSdkYaml(
+      Platform.DART,
+      sampleConnectorYaml,
+      connectorYamlFolder,
+      appFolder,
+    );
+    expect(modifiedYaml.generate?.dartSdk).to.deep.equal({
+      outputDir: "../dataconnect-generated",
+      package: "test_connector",
+    });
+  });
+
   it("should create generate object if it doesn't exist", () => {
     const yamlWithoutGenerate: ConnectorYaml = { connectorId: "test_connector" };
     const modifiedYaml = generateSdkYaml(

src/dataconnect/fileUtils.ts

@@ -111,6 +111,7 @@
 const WEB_INDICATORS = ["package.json", "package-lock.json", "node_modules"];
 const IOS_INDICATORS = ["info.plist", "podfile", "package.swift"];
 const ANDROID_INDICATORS = ["androidmanifest.xml", "build.gradle", "build.gradle.kts"];
+const DART_INDICATORS = ["pubspec.yaml", "pubspec.lock"];
 
 // endswith match
 const IOS_POSTFIX_INDICATORS = [".xcworkspace", ".xcodeproj"];
@@ -123,20 +124,25 @@
   let hasWeb = false;
   let hasAndroid = false;
   let hasIOS = false;
+  let hasDart = false;
   for (const fileName of fileNames) {
     const cleanedFileName = fileName.toLowerCase();
     hasWeb ||= WEB_INDICATORS.some((indicator) => indicator === cleanedFileName);
     hasAndroid ||= ANDROID_INDICATORS.some((indicator) => indicator === cleanedFileName);
     hasIOS ||=
       IOS_INDICATORS.some((indicator) => indicator === cleanedFileName) ||
       IOS_POSTFIX_INDICATORS.some((indicator) => cleanedFileName.endsWith(indicator));
+    hasDart ||=
+      DART_INDICATORS.some((indicator) => indicator === cleanedFileName);
   }
-  if (hasWeb && !hasAndroid && !hasIOS) {
+  if (hasWeb && !hasAndroid && !hasIOS && !hasDart) {
     return Platform.WEB;
-  } else if (hasAndroid && !hasWeb && !hasIOS) {
+  } else if (hasAndroid && !hasWeb && !hasIOS && !hasDart) {
     return Platform.ANDROID;
-  } else if (hasIOS && !hasWeb && !hasAndroid) {
+  } else if (hasIOS && !hasWeb && !hasAndroid && !hasDart) {
     return Platform.IOS;
+  } else if (hasDart && !hasWeb && !hasIOS && !hasAndroid) {
+    return Platform.DART;
   }
   // At this point, its not clear which platform the app directory is
   // (either because we found no indicators, or indicators for multiple platforms)
@@ -179,5 +185,11 @@
       package: `connectors.${connectorYaml.connectorId}`,
     };
   }
+  if (platform === Platform.DART) {
+    connectorYaml.generate.dartSdk = {
+      outputDir,
+      package: connectorYaml.connectorId,
+    };
+  }
   return connectorYaml;
 }

src/dataconnect/types.ts

@@ -132,6 +132,7 @@ export interface Generate {
   javascriptSdk?: JavascriptSDK;
   swiftSdk?: SwiftSDK;
   kotlinSdk?: KotlinSDK;
+  dartSdk?: DartSDK;
 }
 
 export interface JavascriptSDK {
@@ -148,11 +149,16 @@ export interface KotlinSDK {
   outputDir: string;
   package: string;
 }
+export interface DartSDK {
+  outputDir: string;
+  package: string;
+}
 
 export enum Platform {
   ANDROID = "ANDROID",
   WEB = "WEB",
   IOS = "IOS",
+  DART = "DART",
   UNDETERMINED = "UNDETERMINED",
 }
 

src/emulator/dataconnectEmulator.ts

@@ -184,6 +184,7 @@
       `--config_dir=${args.configDir}`,
       `--connector_id=${args.connectorId}`,
     ];
+
     const res = childProcess.spawnSync(commandInfo.binary, cmd, { encoding: "utf-8" });
 
     logger.info(res.stderr);

src/experiments.ts

@@ -1,7 +1,6 @@
 import { bold, italic } from "colorette";
 import * as leven from "leven";
 import { basename } from "path";
-
 import { configstore } from "./configstore";
 import { FirebaseError } from "./error";
 import { isRunningInGithubAction } from "./init/features/hosting/github";

src/init/features/dataconnect/sdk.ts

@@ -15,6 +15,7 @@
 import {
   ConnectorInfo,
   ConnectorYaml,
+  DartSDK,
   JavascriptSDK,
   KotlinSDK,
   Platform,
@@ -23,6 +24,7 @@
 import { FirebaseError } from "../../../error";
 import { camelCase, snakeCase, upperFirst } from "lodash";
 import { logSuccess, logBullet } from "../../../utils";
+import * as experiments from "../../../experiments";
 
 export type SDKInfo = {
   connectorYamlContents: string;
@@ -87,14 +89,16 @@
     } else {
       // If we still can't autodetect, just ask the user
       logBullet("Couldn't automatically detect your app's platform.");
+      const platforms = [
+        { name: "iOS (Swift)", value: Platform.IOS },
+        { name: "Web (JavaScript)", value: Platform.WEB },
+        { name: "Android (Kotlin)", value: Platform.ANDROID },
+        { name: "Flutter (Dart)", value: Platform.DART },
+      ];
       targetPlatform = await promptOnce({
         message: "Which platform do you want to set up a generated SDK for?",
         type: "list",
-        choices: [
-          { name: "iOS (Swift)", value: Platform.IOS },
-          { name: "Web (JavaScript)", value: Platform.WEB },
-          { name: "Android (Kotlin)", value: Platform.ANDROID },
-        ],
+        choices: platforms,
       });
     }
   }
@@ -144,6 +148,21 @@
     newConnectorYaml.generate.javascriptSdk = javascriptSdk;
   }
 
+  if (targetPlatform === Platform.DART) {
+    const outputDir =
+      newConnectorYaml.generate.dartSdk?.outputDir ||
+      path.relative(
+        connectorInfo.directory,
+        path.join(appDir, `generated/dart/${newConnectorYaml.connectorId}`),
+      );
+    const pkg = newConnectorYaml.generate.dartSdk?.package ?? newConnectorYaml.connectorId;
+    const dartSdk: DartSDK = {
+      outputDir,
+      package: pkg,
+    };
+    newConnectorYaml.generate.dartSdk = dartSdk;
+  }
+
   if (targetPlatform === Platform.ANDROID) {
     // app/src/main/kotlin and app/src/main/java are conventional for Android,
     // but not required or enforced. If one of them is present (preferring the