fix: support deployment of an Angular app using legacy browser builder

[9kubczas4]

Description

This change fixes:

• @angular-devkit/build-angular:browser (app:build:production) is not a recognized builder #6908
• Error deploying brand new AngularFire project - @angular-devkit/build-angular:browser (app:build:production) is not a recognized builder. #7029

The fix was done in 2 areas of the code:

• @angular-devkit/build-angular:browser (app:build:production) is not a recognized builder was thrown because @angular-devkit/build-angular:browser wasn't recognized as build target.
• @angular-devkit/build-angular:browser doesn't create browser subfolder in the output path

Scenarios Tested

I've built and deployed to firebase Angular apps (v17) which use:

• @angular-devkit/build-angular:browser
• @angular-devkit/build-angular:application

Sample Commands

[Erkam246]

@9kubczas4 could you provide us the configuration for @angular-devkit/build-angular:application

Im getting:

Error: @angular-devkit/build-angular:application (app:build:production) is not a recognized builder. Please check your angular.json

with this configuration:

"deploy": {
          "builder": "@angular/fire:deploy",
          "options": {
            "version": 2,
            "browserTarget": "app:build:production"
          }
        }

Update got it working by removing the deploy configuration and changing outputPath to a string

[rinebob]

Suggestion from @Erkam246 worked for me. I was trying to start the emulators and getting

c:\aa\projects\friendly-chat>firebase emulators:start
i emulators: Starting emulators: auth, functions, firestore, hosting, storage
...
i emulators: Shutting down emulators.
i hub: Stopping emulator hub

Error: @angular-devkit/build-angular:application (friendlychat:build:production) is not a recognized builder. Please check your angular.json

Removing the deploy configuration from angular.json allowed the emulators to start properly

[deanbiltup]

firebase deploy works but the cloud builder fails until I modify to application and then my local no longer works :(. Also, when I get cloud building it doesn't seem to use my changes at all. It says success but the app never changes from my last firebase deploy :( :( . If I leave browser builder, cloud builder fails.

[9kubczas4]

Hi @deanbiltup,

Could you create a new issue and provide me a little more details like steps to reproduce, logs etc.

Thank you in advance

[deanbiltup]

send me a github user id and I can add you to my github repo since it is just a demo. I can shut it down later as I put it all in a temp project to test out chat.

…

On Thu, Sep 12, 2024 at 5:51 PM Paweł Kubiak ***@***.***> wrote: Hi @deanbiltup <https://github.com/deanbiltup>, Could you provide me a little more details? Steps to reproduce, logs etc. Thank you in advance — Reply to this email directly, view it on GitHub <#7264 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKLBWPEXAQPIVYWFHL7B5S3ZWGS5ZAVCNFSM6AAAAABIYOKHIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWGUZDANZQG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>