Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emulator bump to v1.1.20 #7254

Merged
merged 5 commits into from
Jun 3, 2024
Merged

emulator bump to v1.1.20 #7254

merged 5 commits into from
Jun 3, 2024

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented Jun 3, 2024

Description

Scenarios Tested

Sample Commands

@hlshen hlshen requested a review from rosalyntan June 3, 2024 18:36
@hlshen hlshen changed the title emulator bump to v1.2.20 emulator bump to v1.1.20 Jun 3, 2024
@hlshen hlshen enabled auto-merge (squash) June 3, 2024 18:38
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include change logs

[added] Added Postgres 16 support.

The ConfigureEmulator is an internal detail, don't need to include there.

Since we removed the --local_connection_string flag, we want to test CLI and VS Code in more details as part of a CL.

@hlshen hlshen disabled auto-merge June 3, 2024 18:41
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local_connection_string: this.getLocalConectionString(),

This will be broken.

Can you work with Rosalyn to break it into a separate call? Follow up PR is fine

curl <localAddress>/emulator/configure -X POST -d '{
  "connection_string": "...",
}'

@hlshen hlshen enabled auto-merge (squash) June 3, 2024 18:47
@hlshen hlshen requested a review from fredzqm June 3, 2024 18:47
CHANGELOG.md Outdated Show resolved Hide resolved
@hlshen hlshen merged commit 4397fe4 into master Jun 3, 2024
35 checks passed
hlshen added a commit that referenced this pull request Jun 3, 2024
hlshen added a commit that referenced this pull request Jun 3, 2024
@hlshen hlshen deleted the hlshen/emu-bump branch June 3, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants