Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --inspect-functions across multiple codebases #6854

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

inlined
Copy link
Member

@inlined inlined commented Mar 8, 2024

Addresses feature request in #6817.

When testing I was able to get this to work, but unfortunately Chrome doesn't scan all ports, so you need to manually add the address in Chrome:

Snippet from the console output in testing:

...
✔  functions: Using debug port 9229 for functions codebase default
...
✔  functions: Using debug port 9230 for functions codebase functions2

We start with port 9229 as it's default configured in Chrome. Additional ports will need to be added manually.

9gx4KbM9dFhTHxw

Gsy9oxW9EA4SEme

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 54.24%. Comparing base (6c88d82) to head (37f7889).
Report is 565 commits behind head on master.

Files with missing lines Patch % Lines
src/emulator/functionsEmulator.ts 0.00% 11 Missing ⚠️
src/emulator/commandUtils.ts 16.66% 5 Missing ⚠️
src/emulator/controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6854      +/-   ##
==========================================
- Coverage   54.26%   54.24%   -0.02%     
==========================================
  Files         352      352              
  Lines       24519    24531      +12     
  Branches     5075     5079       +4     
==========================================
+ Hits        13305    13307       +2     
- Misses       9998    10009      +11     
+ Partials     1216     1215       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion to head off issues/

this.logger.logLabeled(
"SUCCESS",
"functions",
`Using debug port ${port} for functions codebase ${backend.codebase}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ports other than 9299, maybe remind users that they will have to add the port to inspector manually in this message - ie:

Using debug port 9300 for functions codebase ${backend.codebase}. You may need to add manually add this port to your inspector.

@inlined inlined merged commit ede7d0b into master Mar 13, 2024
35 checks passed
@inlined inlined deleted the inlined.multi-inspect branch March 13, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants