Improve FAH onboarding flow to connect backends with SCMs #6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6764 +/- ##
==========================================
- Coverage 54.31% 54.31% -0.01%
==========================================
Files 349 349
Lines 24283 24312 +29
Branches 5021 5026 +5
==========================================
+ Hits 13190 13204 +14
- Misses 9888 9902 +14
- Partials 1205 1206 +1 ☔ View full report in Codecov by Sentry. |
tonyjhuang
approved these changes
Feb 15, 2024
src/gcp/cloudbuild.ts
Outdated
| const res = await client.get<LinkableRepositories>(name); | ||
| const res = await client.get<LinkableRepositories>(name, { | ||
| queryParams: { | ||
| pageSize: 20, |
There was a problem hiding this comment.
I would consider passing this in by arg as well. We may as well request a page size of 1000 if we're trying to fetch all repos
src/init/features/apphosting/repo.ts
Outdated
| @@ -226,6 +257,9 @@ async function promptAppInstall(conn: gcb.Connection): Promise<gcb.Connection> { | |||
| return await gcb.getConnection(projectId, location, id); | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of different issues with connecting repos to FAH backends: