Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pinTags + minInstances from any functions, not just frameworks #6684

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

inlined
Copy link
Member

@inlined inlined commented Jan 12, 2024

We previously removed pinTags from the web frameworks configuration options because it is a foot gun, but customers could still hurt themselves if they turn on pinTags with a manual Function rewrite. This prevents the footgun at the API layer.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6b0cb5d) 54.18% compared to head (8c6825c) 54.18%.

Files Patch % Lines
src/deploy/hosting/convertConfig.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6684      +/-   ##
==========================================
- Coverage   54.18%   54.18%   -0.01%     
==========================================
  Files         347      347              
  Lines       24130    24132       +2     
  Branches     4976     4977       +1     
==========================================
  Hits        13075    13075              
- Misses       9855     9856       +1     
- Partials     1200     1201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Berlioz Berlioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inlined inlined merged commit d5a179a into master Jan 16, 2024
35 checks passed
@inlined inlined deleted the inlined.tag-pinning-min-instances branch January 16, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants