Skip to content

Commit

Permalink
Update ALLOWED_SSR_REGIONS constant for web frameworks (#6591)
Browse files Browse the repository at this point in the history
Update list of `ALLOWED_SSR_REGIONS` in web frameworks config to include the current list of regions that support gen 2 Cloud Functions.

---------

Co-authored-by: James Xabregas <james@sparkello.com>
Co-authored-by: Alex Astrum <sandu@google.com>
  • Loading branch information
3 people authored Dec 7, 2023
1 parent 49ec949 commit b8ef5fa
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
- Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)
- Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562)
- Use Web Framework's well known version range in `firebase init hosting`. (#6562)
- Permit use of more SSR regions in Web Frameworks deploys. (#6086)
- Limit Web Framework's generated Cloud Function name to 23 characters, fixing deploys for some. (#6260)
34 changes: 29 additions & 5 deletions src/frameworks/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,35 @@ export const VALID_LOCALE_FORMATS = [/^ALL_[a-z]+$/, /^[a-z]+_ALL$/, /^[a-z]+(_[

export const DEFAULT_REGION = "us-central1";
export const ALLOWED_SSR_REGIONS = [
{ name: "us-central1 (Iowa)", value: "us-central1" },
{ name: "us-west1 (Oregon)", value: "us-west1" },
{ name: "us-east1 (South Carolina)", value: "us-east1" },
{ name: "europe-west1 (Belgium)", value: "europe-west1" },
{ name: "asia-east1 (Taiwan)", value: "asia-east1" },
{ name: "us-central1 (Iowa)", value: "us-central1", recommended: true },
{ name: "us-east1 (South Carolina)", value: "us-east1", recommended: true },
{ name: "us-east4 (Northern Virginia)", value: "us-east4" },
{ name: "us-west1 (Oregon)", value: "us-west1", recommended: true },
{ name: "us-west2 (Los Angeles)", value: "us-west2" },
{ name: "us-west3 (Salt Lake City)", value: "us-west3" },
{ name: "us-west4 (Las Vegas)", value: "us-west4" },
{ name: "asia-east1 (Taiwan)", value: "asia-east1", recommended: true },
{ name: "asia-east2 (Hong Kong)", value: "asia-east2" },
{ name: "asia-northeast1 (Tokyo)", value: "asia-northeast1" },
{ name: "asia-northeast2 (Osaka)", value: "asia-northeast2" },
{ name: "asia-northeast3 (Seoul)", value: "asia-northeast3" },
{ name: "asia-south1 (Mumbai)", value: "asia-south1" },
{ name: "asia-south2 (Delhi)", value: "asia-south2" },
{ name: "asia-southeast1 (Singapore)", value: "asia-southeast1" },
{ name: "asia-southeast2 (Jakarta)", value: "asia-southeast2" },
{ name: "australia-southeast1 (Sydney)", value: "australia-southeast1" },
{ name: "australia-southeast2 (Melbourne)", value: "australia-southeast2" },
{ name: "europe-central2 (Warsaw)", value: "europe-central2" },
{ name: "europe-north1 (Finland)", value: "europe-north1" },
{ name: "europe-west1 (Belgium)", value: "europe-west1", recommended: true },
{ name: "europe-west2 (London)", value: "europe-west2" },
{ name: "europe-west3 (Frankfurt)", value: "europe-west3" },
{ name: "europe-west4 (Netherlands)", value: "europe-west4" },
{ name: "europe-west6 (Zurich)", value: "europe-west6" },
{ name: "northamerica-northeast1 (Montreal)", value: "northamerica-northeast1" },
{ name: "northamerica-northeast2 (Toronto)", value: "northamerica-northeast2" },
{ name: "southamerica-east1 (São Paulo)", value: "southamerica-east1" },
{ name: "southamerica-west1 (Santiago)", value: "southamerica-west1" },
];

export const I18N_ROOT = "/";
Expand Down
2 changes: 1 addition & 1 deletion src/init/features/hosting/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export async function doSetup(setup: any, config: any, options: Options): Promis
type: "list",
message: "In which region would you like to host server-side content, if applicable?",
default: DEFAULT_REGION,
choices: ALLOWED_SSR_REGIONS,
choices: ALLOWED_SSR_REGIONS.filter((region) => region.recommended),
},
setup.hosting
);
Expand Down

0 comments on commit b8ef5fa

Please sign in to comment.