fix: handle paths with spaces in getGlobalEsbuildVersion function (#7571

) * fix: handle paths with spaces in getGlobalEsbuildVersion function * fix failing test
firebase · Sep 18, 2024 · 6bd497d · 6bd497d
1 parent e1d1563
commit 6bd497d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/frameworks/next/utils.spec.ts b/src/frameworks/next/utils.spec.ts
@@ -578,7 +578,7 @@ describe("Next.js utils", () => {
         .withArgs("npx which esbuild", { encoding: "utf8" })
         .returns(mockBinaryPath + "\n");
       execSyncStub
-        .withArgs(`${mockBinaryPath} --version`, { encoding: "utf8" })
+        .withArgs(`"${mockBinaryPath}" --version`, { encoding: "utf8" })
         .returns(`${mockGlobalVersion}\n`);
 
       const consoleWarnStub = sinon.stub(console, "warn");

diff --git a/src/frameworks/next/utils.ts b/src/frameworks/next/utils.ts
@@ -521,7 +521,7 @@ export function findEsbuildPath(): string | null {
  */
 export function getGlobalEsbuildVersion(binPath: string): string | null {
   try {
-    const versionOutput = execSync(`${binPath} --version`, { encoding: "utf8" })?.trim();
+    const versionOutput = execSync(`"${binPath}" --version`, { encoding: "utf8" })?.trim();
     if (!versionOutput) {
       return null;
     }