Include serving locality in create backend requests.

firebase · Dec 6, 2023 · 5ce2747 · 5ce2747
1 parent c2ea584
commit 5ce2747
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/gcp/frameworks.ts b/src/gcp/frameworks.ts
@@ -19,11 +19,14 @@ interface Codebase {
   rootDirectory: string;
 }
 
+export type ServingLocality = "GLOBAL_ACCESS" | "REGIONAL_STRICT";
+
 /** A Backend, the primary resource of Frameworks. */
 export interface Backend {
   name: string;
   mode?: string;
   codebase: Codebase;
+  servingLocality: ServingLocality;
   labels: Record<string, string>;
   createTime: string;
   updateTime: string;

diff --git a/src/init/features/frameworks/index.ts b/src/init/features/frameworks/index.ts
@@ -69,6 +69,7 @@ export async function doSetup(setup: any, projectId: string): Promise<void> {
 
 function toBackend(cloudBuildConnRepo: Repository): Omit<Backend, BackendOutputOnlyFields> {
   return {
+    servingLocality: "GLOBAL_ACCESS",
     codebase: {
       repository: `${cloudBuildConnRepo.name}`,
       rootDirectory: "/",

diff --git a/src/test/init/frameworks/index.spec.ts b/src/test/init/frameworks/index.spec.ts
@@ -60,7 +60,8 @@ describe("operationsConverter", () => {
       createTime: "0",
       updateTime: "1",
     };
-    const backendInput = {
+    const backendInput: Omit<gcp.Backend, gcp.BackendOutputOnlyFields> = {
+      servingLocality: "GLOBAL_ACCESS",
       codebase: {
         repository: cloudBuildConnRepo.name,
         rootDirectory: "/",