FAH bugfixes (#6754)

* FAH bugfixes * Changelog
firebase · Feb 9, 2024 · 0d975e3 · 0d975e3
1 parent ae24af6
commit 0d975e3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+Bugfixes to internal utilities (#6754)
diff --git a/src/commands/apphosting-builds-create.ts b/src/commands/apphosting-builds-create.ts
@@ -16,12 +16,12 @@ export const command = new Command("apphosting:builds:create <backendId>")
     const buildId =
       (options.buildId as string) ||
       (await apphosting.getNextRolloutId(projectId, location, backendId));
-    const branch = options.branch as string;
+    const branch = (options.branch as string | undefined) ?? "main";
 
     const op = await apphosting.createBuild(projectId, location, backendId, buildId, {
       source: {
         codebase: {
-          branch: "main",
+          branch,
         },
       },
     });

diff --git a/src/gcp/apphosting.ts b/src/gcp/apphosting.ts
@@ -531,7 +531,7 @@ export async function getNextRolloutId(
   const year = date.getUTCFullYear();
   // Note: month is 0 based in JS
   const month = String(date.getUTCMonth() + 1).padStart(2, "0");
-  const day = String(date.getUTCDay()).padStart(2, "0");
+  const day = String(date.getUTCDate()).padStart(2, "0");
 
   if (counter) {
     return `build-${year}-${month}-${day}-${String(counter).padStart(3, "0")}`;

diff --git a/src/test/gcp/apphosting.spec.ts b/src/test/gcp/apphosting.spec.ts
@@ -17,7 +17,7 @@ describe("apphosting", () => {
     function idPrefix(date: Date): string {
       const year = date.getUTCFullYear();
       const month = String(date.getUTCMonth() + 1).padStart(2, "0");
-      const day = String(date.getUTCDay()).padStart(2, "0");
+      const day = String(date.getUTCDate()).padStart(2, "0");
       return `build-${year}-${month}-${day}`;
     }