Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP server shutdown message #1457

Merged
merged 2 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Remove HTTP server shutdown message. (#1457)
- Add features to task queue functions. (#1423)
- Add traces to V2 Firestore trigger logs. (#1440)
2 changes: 1 addition & 1 deletion src/bin/firebase-functions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const app = express();

function handleQuitquitquit(req: express.Request, res: express.Response) {
res.send("ok");
server.close(() => console.log("shutdown requested via /__/quitquitquit"));
server.close();
}

app.get("/__/quitquitquit", handleQuitquitquit);
Expand Down
2 changes: 1 addition & 1 deletion src/v2/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export function getGlobalOptions(): GlobalOptions {
* Additional fields that can be set on any event-handling function.
*/
export interface EventHandlerOptions extends Omit<GlobalOptions, "enforceAppCheck"> {
/** Type of the event. Valid values are TODO */
/** Type of the event. Valid values are TODO */
eventType?: string;

/** TODO */
Expand Down
Loading