-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netlify.toml
with build base directory specified
#325
Add netlify.toml
with build base directory specified
#325
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Thanks for this @JamieSlome ! I'm not sure this is the right solution (in fact, this PR should not have triggered the build/preview in theory); please keep in mind that we also need to rebuild against changes to the I'd suggest the following content on netlify.toml:
This is currently working for FDC3, see https://github.com/finos/FDC3/blob/master/netlify.toml |
How can we re-test this @mao? |
@JamieSlome , just realised that
Re. testing, it's probably ok to merge and run some PRs to see what's going on. I know it's not ideal. |
Updated, but still seems to be running even on this PR (@maoo) |
Could be that netlify.toml changes always triggers a build? Found this discussion to be relevant - https://answers.netlify.com/t/builds-cancelled-for-a-new-branch-due-to-no-content-change/17169 I'd try to merge some of these changes to main and see if there's any change in behaviour. |
Closes #324