Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netlify.toml with build base directory specified #325

Conversation

JamieSlome
Copy link
Member

Closes #324

@JamieSlome JamieSlome added the documentation Improvements or additions to documentation label Oct 25, 2023
@JamieSlome JamieSlome self-assigned this Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 0957365
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/653bd48b7032aa00088e1651

@maoo
Copy link
Member

maoo commented Oct 25, 2023

Thanks for this @JamieSlome !

I'm not sure this is the right solution (in fact, this PR should not have triggered the build/preview in theory); please keep in mind that we also need to rebuild against changes to the docs folder.

I'd suggest the following content on netlify.toml:

[build]
  ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../{docs,website}/"

This is currently working for FDC3, see https://github.com/finos/FDC3/blob/master/netlify.toml

@JamieSlome
Copy link
Member Author

How can we re-test this @mao?

@maoo
Copy link
Member

maoo commented Oct 27, 2023

@JamieSlome , just realised that docs is a subfolder of website, so we can probably update this to :

[build]
  ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../website/"

Re. testing, it's probably ok to merge and run some PRs to see what's going on. I know it's not ideal.

@JamieSlome
Copy link
Member Author

Updated, but still seems to be running even on this PR (@maoo)

@maoo
Copy link
Member

maoo commented Oct 27, 2023

Updated, but still seems to be running even on this PR (@maoo)

Could be that netlify.toml changes always triggers a build? Found this discussion to be relevant - https://answers.netlify.com/t/builds-cancelled-for-a-new-branch-due-to-no-content-change/17169

I'd try to merge some of these changes to main and see if there's any change in behaviour.

@JamieSlome JamieSlome merged commit d7df3bc into main Oct 27, 2023
8 checks passed
@JamieSlome JamieSlome deleted the 324-only-run-doc-build-process-with-changes-are-made-exclusively-to-the-docs branch October 27, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only run doc build process with changes are made exclusively to the docs
2 participants