-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLINT and Prettier with autosave #212
Add ESLINT and Prettier with autosave #212
Conversation
…add-eslint-prettier-autosave
Hey @JamieSlome! Sorry about the delay with this PR. Didn't find time from daily work to close this sooner. |
@TheJuanAndOnly99 - can we make the linting check a requirement for PRs prior to merging in the repository settings? |
@vaibssingh, my last question is, how will the results be reported to the developer? In the GitHub Actions console? |
@maoo - sorry to be a pain, but can we disable the check requirement for the time being? It seems to be preventing the merging of all other PRs, and I still need to review the contents of this PR 🤗 |
@JamieSlome Yep. It would look something like this |
@JamieSlome I've removed the linting check for now. Let me know when you're ready and I can enable it again. |
Thank you, @TheJuanAndOnly99 😄 |
@vaibssingh - my bad, are you able to resolve the merge conflicts? Deleting the |
@vaibssingh - looks like there is still a merge conflict for some reason. Once that is addressed, we can merge! 🎉 |
…add-eslint-prettier-autosave
@JamieSlome Fixed the conflict but now it is failing the CVE test 😭 |
@vaibssingh - do you want to give the latest merge conflict a go and see if that resolves the CVE breakage? 👍 Thank you for your patience! 🍰 |
Hey @JamieSlome , I have tried multiple times for this to work but I am not able to get it resolved. The material-ui requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
…tier-autosave Add ESLINT and Prettier with autosave
Closes #193
Changelog:
Notes:
eslintrc
have been disabled/modified to avoid conflicting rules between eslint & prettier and to follow the existing standards of the repo.Don't run codeActionsOnSave on focus changes microsoft/vscode#121155