Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix DICEModel and submodels, added external forcing #93

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

maxsing
Copy link
Contributor

@maxsing maxsing commented Jun 4, 2023

What is this PR for?

Bug Fix for Submodels and DICEModel class.

What type of PR is it?

Bug Fix

@cfries cfries changed the base branch from master to feature/dice-model-consistency July 21, 2023 13:27
@cfries cfries merged commit af9a987 into finmath:feature/dice-model-consistency Jul 21, 2023
@cfries
Copy link
Member

cfries commented Jul 21, 2023

Hi Max.

Ich habe das mal gemerged, werde aber die erwähnten Stellen oben noch mal zurück ändern (die Damage Funktion auf D/(1+D) wie in der älteren Version des Papers. Mann kann ja zwei Damage Funktionen bereitstellen (seltsam nur, dass sie die gleichen Parameter haben - das kann ja eigentlich nicht stimmen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants