Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lotus-shed: store processed tipset after backfilling events #12335

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fix: lotus-shed: store processed tipset after backfilling events #12335

merged 3 commits into from
Aug 5, 2024

Conversation

akaladarshi
Copy link
Contributor

Related Issues

Fixes: #12334

Proposed Changes

store processed tipset in event-seen table after backfilling the events in lotus-shed backfill-event

@akaladarshi
Copy link
Contributor Author

@rvagg, I am not able to add skip/changelog label into this PR.

Can you help me with that.

@aarshkshah1992 aarshkshah1992 added skip/changelog This change does not require CHANGELOG.md update and removed skip/changelog This change does not require CHANGELOG.md update labels Aug 2, 2024
@aarshkshah1992
Copy link
Contributor

@akaladarshi Please can you update the CHANGELOG.MD file to record this bug fix ?

@aarshkshah1992 aarshkshah1992 self-requested a review August 2, 2024 06:08
@akaladarshi akaladarshi changed the title feat: store processed tipset after backfilling events fix: store processed tipset after backfilling events Aug 2, 2024
aarshkshah1992
aarshkshah1992 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just need to update the ChangeLog. Thanks a lot.

rvagg
rvagg reviewed Aug 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
rvagg
rvagg approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm good with this except for the minor fix in the changelog - I'm also going to rename the PR to the same and we should do likewise when we squash merge this so it's in the commit log like this.

@rvagg rvagg changed the title fix: store processed tipset after backfilling events fix: lotus-shed: store processed tipset after backfilling events Aug 3, 2024
@akaladarshi akaladarshi requested a review from rvagg August 3, 2024 05:56
@rvagg rvagg merged commit d44dc15 into filecoin-project:master Aug 5, 2024
82 checks passed
@akaladarshi akaladarshi deleted the akaladarshi/store-event-seen-backfill-events branch August 5, 2024 04:25
rjan90 pushed a commit that referenced this pull request Aug 12, 2024
@akaladarshi @rjan90
fix: lotus-shed: store processed tipset after backfilling events (#12335
436d96c 
)
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
@akaladarshi @ribasushi
fix: lotus-shed: store processed tipset after backfilling events (fil…
a15873a 
…ecoin-project#12335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@aarshkshah1992 aarshkshah1992 aarshkshah1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lotus-shed backfill events doesn't touch events_seen
3 participants
@akaladarshi @aarshkshah1992 @rvagg