This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Implement /v1/retrieval-events handler #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehuntsman
force-pushed
the
feat/go-api
branch
from
c13070e
to
7e91612
Compare
masih
reviewed
Mar 2, 2023
| Phase *types.Phase `json:"phase"` | ||
| PhaseStartTime *time.Time `json:"phaseStartTime"` | ||
| EventName *types.EventCode `json:"eventName"` | ||
| EventTime *time.Time `json:"eventTime"` |
There was a problem hiding this comment.
Are these all pointers because they are optional fields? Validation implementation suggests otherwise. Which leaves the question why pointers?
There was a problem hiding this comment.
I needed them to be pointers because I need to check if their values are nil to gaurd against missing properties.
There was a problem hiding this comment.
I am curious why not check for zero values?
| event.EventTime, | ||
| event.EventDetails, | ||
| } | ||
| _, err := r.db.Exec(ctx, query, values...) |
There was a problem hiding this comment.
I tried reading the docs and couldn't understand how to make that work. I agree though. I ended up here just to get something working.
kylehuntsman
force-pushed
the
feat/go-api
branch
from
7e91612
to
9c2b153
Compare
masih
approved these changes
Mar 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
/v1/retrieval-eventshandler.Demo
The demo spins up Postgres in Docker, runs the event recorder Docker container, creates the table in Postgres, POSTs to the container, and then views the event in Postgres via psql.
WindowsTerminal_QwplT41wEs.mp4