This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Relax timing requirement #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow 24 hour grace period to deal with the weird idiosyncracies of time
willscott
approved these changes
Mar 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix #24
Implementation
While theoretically we shouldn't get requests for events with times in the future, times are weird, and timezones are weird. Experimentally, we can see in the logs about 1 in 100 events getting rejected for this reason.
This PR allows 24 hour grace period to deal with the weird idiosyncracies of time. It also adds some logs we can monitor for events in the grace period to verify if there is actually a code error or this is indeed weird time or time zone idiosyncracies.