Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update current http urls as per #960 #975

Merged
merged 8 commits into from
Nov 22, 2022
Merged

fix: update current http urls as per #960 #975

merged 8 commits into from
Nov 22, 2022

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Nov 21, 2022

Fixes part of #960

@LexLuthr LexLuthr changed the title fix: update current http urls as per https://github.com/filecoin-project/boost/issues/960 fix: update current http urls as per #960 Nov 21, 2022
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we

  • remove the format parameter from the /piece endpoint, as it can only ever have one value so it's redundant
  • remove all code related to building car files
  • note that we should also remove any methods from HttpServerApi and its implementation that are no longer used

We can always find this code in the commit history if we need it later

cmd/booster-http/server.go Outdated Show resolved Hide resolved
cmd/booster-http/server.go Outdated Show resolved Hide resolved
cmd/booster-http/server.go Outdated Show resolved Hide resolved
@LexLuthr
Copy link
Collaborator Author

@jacobheun Please let me know what's the final call on Dirk's comment. It makes sense to remove that param as it is not adding any value.

@jacobheun
Copy link
Contributor

@LexLuthr agreed on removing it as there's only 1 option.

@jacobheun jacobheun added this to the 1.5.1 milestone Nov 22, 2022
@dirkmc
Copy link
Contributor

dirkmc commented Nov 22, 2022

Let's remove PiecesContainingMultihash and GetMaxPieceOffset from HttpServerApi as they are no longer used.
Let's also remove the implementations from serverApi

@LexLuthr LexLuthr merged commit ba8936b into main Nov 22, 2022
@LexLuthr LexLuthr deleted the fix/http-URLS branch November 22, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants