-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRC-0046 First draft of fungible token standard. #435
Conversation
I see that |
@Kubuxu - I understood the purpose of granularity differently. Love a few more examples from you as I may have missed important use cases. my understanding is everything has 18 DP as this being different is an endless source of client bugs. However, in certain use cases it doesn’t make sense to hold or transact partial tokens. my goto example is games. Eg. Rupees in Zelda have to be ‘whole’ for use in game and therefore trading. My assumption was in filecoin this kind of use case would be rare. However, would love to hear other motivations/examples of ways you think this would come in handy. |
Let's take granularity discussion to #407 (comment) and leave this review for FRC style/completeness. |
hi - this is our FRC-0046 |
I have pushed a new commit which:
|
is this ready for review? for fip editor? |
@jennijuju I think it is, but I think there's one more round of minor tweaks coming, so let's wait just a week more. |
I have pushed updates to
Let's leave this for a day or two, but then I think it's ready for merge. Of course it's still in draft. |
This is the first draft of a fungible token standard API for native actors, as discussed in #407
An implementation of this standard is in development at https://github.com/helix-onchain/filecoin/tree/main/fil_fungible_token
FYI @jsuresh, @alexytsu @ZenGround0