Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP-0043 Introduce Domain Separation FIP #423

Closed
wants to merge 1 commit into from

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Aug 2, 2022

First draft of a FIP for adding Signature Domain Separation Tags, see #387.

An open question is how to deal with BLS Signature Aggregation. Feedback welcome!

@geoff-vball geoff-vball force-pushed the gstuart/domain-separation-fip branch from 0ec163e to 665e28a Compare August 3, 2022 20:35
@jennijuju jennijuju changed the title Introduce Domain Separation FIP FIP-0043 Introduce Domain Separation FIP Aug 30, 2022
@anorth
Copy link
Member

anorth commented Nov 16, 2022

I think this draft is not quite in a clear enough state to merge. The specification for protocol level changes is not clear, and there are quite a few open questions. It's been sitting here for a while. I'd suggest we close this PR unless it will be actively worked on in the near future. The FIP number can stay reserved for when someone does pick it up, though.

@jennijuju
Copy link
Member

converting to draft for now, @geoff-vball plz reopen for review when its ready again

@jennijuju jennijuju marked this pull request as draft November 22, 2022 07:10
@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 24, 2022

It would be great if FIP-0044 included DST as well.

@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 28, 2022

After thinking about it more, I would upgrade the "great" to "strong should".
FIP-0044 is a standard we want other people to adopt, the lack of DST will cause long-term security issues and the transition to DST enabled version of FIP-0044 will be hard.

cc @Stebalien

@kaitlin-beegle
Copy link
Collaborator

Closing for now. Seems like the benefits of this FRC have been incorporated as part of follow-on FIPs, and that this draft is not currently moving towards readiness. Feel free to reopen if that changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants