Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP: Filecoin Message Replay Protection #300

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

q9f
Copy link
Member

@q9f q9f commented Feb 16, 2022

Discussion to: #301

Summary: Defines Filecoin chain identifiers and adds them to unsigned messages and signatures to prevent transactions to be replayed across different Filecoin networks.

Note: I'm new to Filecoin and might have missed something in the specification. Feel free to point to everything I should now.

@q9f q9f changed the title Filecoin Message Replay Protection FIP: Filecoin Message Replay Protection Feb 16, 2022
@jleni
Copy link

jleni commented Feb 16, 2022

included my comment in #301

@kaitlin-beegle
Copy link
Collaborator

Hey @q9f! Perhaps I missed the thread- can I ask why you closed this FIP? Do you no longer plan to work on it?

@q9f
Copy link
Member Author

q9f commented May 12, 2022

It hasn't been accepted as a draft and I considered it no longer desired.

@raulk
Copy link
Member

raulk commented May 12, 2022

I think this draft should be merged. The lack of replay protection becomes even more important with user-programmability and user wallets interacting directly with on-chain actors.

@kaitlin-beegle
Copy link
Collaborator

@q9f as long as you don't disagree, I'm reopening this issue. It simply hadn't been merged because FIP editors hadn't been able to provide feedback yet.

Oftentimes, PRs stay open until multiple rounds of revision have taken place. However, FIP editors have all been pretty heads-down on the FVM FIPs. Replay protection may not be an immediate priority, but it's still important.

In general, we are quite capacity limited, and governance topics intentionally move quite slowly. If you have questions or want to push on us, please do so! But no need to close issues and PRs- if the idea wasn't viable, you would know.

@q9f
Copy link
Member Author

q9f commented May 13, 2022

Ok, that's fine. Maybe, I just misunderstood the process. I thought assigning a number and merging a draft is a no-brainer.

@kaitlin-beegle kaitlin-beegle merged commit cf7d8f6 into filecoin-project:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants