Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inputs for headers, query params, to stretch when focused (like HTTPie) #234

Merged
merged 26 commits into from
Sep 20, 2024

Conversation

brettimus
Copy link
Contributor

@brettimus brettimus commented Sep 4, 2024

TODO

  • Press ESC to blur input
  • Investigate why newlines are possible in FireFox
  • Test safari.... 🙈

Summary

This PR introduces a new input-like component that we can use for adding query/path parameters and headers in their respective forms.

It also factors out the codemirror editor components into their own module in the components directory

httpie-inputs.mp4

@brettimus brettimus force-pushed the prototype-stretchy-inputs-for-keyvalue-form branch from 80ab7a3 to 2ee130b Compare September 16, 2024 15:03
Copy link

pkg-pr-new bot commented Sep 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/studio@234
pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/hono-otel@234

commit: 2e0b67b

@brettimus brettimus force-pushed the prototype-stretchy-inputs-for-keyvalue-form branch from 6a06164 to fc6441d Compare September 16, 2024 16:45
@brettimus
Copy link
Contributor Author

Hmmm one annoying thing that came up is that the codemirror inputs swallow our keyboard shortcuts (cmd+g and cmd+b) when they have focus

@brettimus brettimus marked this pull request as ready for review September 17, 2024 16:47
@brettimus brettimus force-pushed the prototype-stretchy-inputs-for-keyvalue-form branch from 9a0a1ab to a51d58b Compare September 18, 2024 09:05
Copy link
Member

@keturiosakys keturiosakys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ideally we'd "blur" the text input when you hit Escape so that it would unblock using the cmd+b and other keyboard shortcuts.

@brettimus brettimus force-pushed the prototype-stretchy-inputs-for-keyvalue-form branch from a51d58b to da44bb3 Compare September 19, 2024 15:20
@brettimus
Copy link
Contributor Author

Looks good! Ideally we'd "blur" the text input when you hit Escape so that it would unblock using the cmd+b and other keyboard shortcuts.

did it!

Copy link
Member

@flenter flenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@brettimus brettimus force-pushed the prototype-stretchy-inputs-for-keyvalue-form branch from cd2a46e to 92d98b6 Compare September 20, 2024 08:33
@brettimus brettimus merged commit ab0f048 into main Sep 20, 2024
3 checks passed
@brettimus brettimus deleted the prototype-stretchy-inputs-for-keyvalue-form branch September 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants