[CU-9ux4p3] Base 64 encode the headers only when necessary #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudmorisset
requested review from
kdisneur,
alli5723,
MatheusBueno782 and
babariviere
alli5723
approved these changes
Nov 9, 2020
kdisneur
approved these changes
Nov 9, 2020
arnaudmorisset
deleted the
CU-9ux4p3_base64-encode-headers-only-when-necessary
branch
MatheusBueno782
added a commit
that referenced
this pull request
Nov 24, 2020
Bump to v3.1.0 This release contains: Fix for using custom config with response: true by bumping bamboo version to ~> 1.6 (#150) Implement our custom test adapter ([#151]) Fix CI random failure by attaching FakeGenSMTP Server process to Test supervision tree.(#153) Add Content-ID header when needed(#154) Base 64 encode the headers only when the content contains non-ASCII characters.(#155) Handle :permanent_failure exception and re-raising it as a SMTPError.(#156) After bumping the dependencies, the project requires(#149): credo ~> 1.4.1 bamboo ~> 1.6 excoveralls ~> 0.13.3 gen_smtp ~> 1.0.1
MatheusBueno782
added a commit
that referenced
this pull request
Nov 24, 2020
Bump to v3.1.0 This release contains: Fix for using custom config with response: true by bumping bamboo version to ~> 1.6 (#150) Implement our custom test adapter ([#151]) Fix CI random failure by attaching FakeGenSMTP Server process to Test supervision tree.(#153) Add Content-ID header when needed(#154) Base 64 encode the headers only when the content contains non-ASCII characters.(#155) Handle :permanent_failure exception and re-raising it as a SMTPError.(#156) After bumping the dependencies, the project requires(#149): credo ~> 1.4.1 bamboo ~> 1.6 excoveralls ~> 0.13.3 gen_smtp ~> 1.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the function
rfc822_encodeto make it Base64 encode only when the content contains non-ASCII characters.Some spam filters have a policy, regarding encoded headers, that can lead to mark legit emails as spam. We should encode headers only when necessary.