Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bamboo.SMTPAdapter.rfc822_encode/1 error #59

Closed
joshuataylor opened this issue Jun 13, 2017 · 3 comments
Closed

Bamboo.SMTPAdapter.rfc822_encode/1 error #59

joshuataylor opened this issue Jun 13, 2017 · 3 comments
Assignees
Labels

Comments

@joshuataylor
Copy link

Process #PID<0.32722.14> terminating: {:function_clause, [{Base, :encode64, [nil, []], [file: 'lib/base.ex', line: 278]}, {Bamboo.SMTPAdapter, :rfc822_encode, 1, [file: 'lib/bamboo/adapters/smtp_adapter.ex', line: 149]}, {Bamboo.SMTPAdapter, :add_subject, 2, [file: 'lib/bamboo/adapters/smtp_adapter.ex', line: 145]}, {Bamboo.SMTPAdapter, :body, 1, [file: 'lib/bamboo/adapters/smtp_adapter.ex', line: 190]}, {Bamboo.SMTPAdapter, :to_gen_smtp_message, 1, [file: 'lib/bamboo/adapters/smtp_adapter.ex', line: 282]}, {Bamboo.SMTPAdapter, :deliver, 2, [file: 'lib/bamboo/adapters/smtp_adapter.ex', line: 61]}, {Task.Supervised, :do_apply, 2, [file: 'lib/task/supervised.ex', line: 85]}, {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 247]}]}

Backtrace

(bamboo_smtp) lib/bamboo/adapters/smtp_adapter.ex:149: Bamboo.SMTPAdapter.rfc822_encode/1
(bamboo_smtp) lib/bamboo/adapters/smtp_adapter.ex:145: Bamboo.SMTPAdapter.add_subject/2
(bamboo_smtp) lib/bamboo/adapters/smtp_adapter.ex:190: Bamboo.SMTPAdapter.body/1
(bamboo_smtp) lib/bamboo/adapters/smtp_adapter.ex:282: Bamboo.SMTPAdapter.to_gen_smtp_message/1
(bamboo_smtp) lib/bamboo/adapters/smtp_adapter.ex:61: Bamboo.SMTPAdapter.deliver/2
(elixir) lib/task/supervised.ex:85: Task.Supervised.do_apply/2
(stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3

Mail still sends, this error doesn't show up every time, just sometimes.

@kdisneur
Copy link
Contributor

Hi @joshuataylor,

The stacktrace seems to suggest the subject field is nil. Is it possible you send some emails with no subjects?

@joshuataylor
Copy link
Author

@kdisneur apologies for not seeing this update. I might be, but it looks like the newest release fixes this anyway - awesome work! Will upgrade soon.

@kdisneur
Copy link
Contributor

Yes it was just to be sure we tackle the right problem. But, anyway, we needed to fix this "no subject" issue.

Thanks for the bug report, hopefully this new release will fix your issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants