Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for Fund ValidateBasic and Drip function #100

Merged
merged 5 commits into from
Jul 19, 2021

Conversation

Josumner
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #100 (adaedf0) into master (73de69d) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   62.99%   62.93%   -0.07%     
==========================================
  Files         626      631       +5     
  Lines       41425    41472      +47     
==========================================
+ Hits        26097    26100       +3     
- Misses      12929    12974      +45     
+ Partials     2399     2398       -1     
Impacted Files Coverage Δ
x/staking/keeper/test_common.go
x/auth/vesting/types/test_common.go
x/airdrop/types/msgs.go 45.83% <0.00%> (ø)
x/airdrop/types/querier.go 0.00% <0.00%> (ø)
x/airdrop/types/codec.go 0.00% <0.00%> (ø)
x/airdrop/types/params.go 0.00% <0.00%> (ø)
x/airdrop/types/genesis.go 0.00% <0.00%> (ø)
x/airdrop/types/airdrop.go 86.66% <0.00%> (ø)
x/airdrop/types/keys.go 0.00% <0.00%> (ø)

Copy link
Contributor

@daeMOn63 daeMOn63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Using table-driven tests here would have made it a bit more goish (and easier to maintain/extend in the long run) but that'll be fine for now 👍 Give it a try for the next ones!

@Josumner Josumner merged commit 8ee135e into master Jul 19, 2021
@Josumner Josumner deleted the msgs_airdrop_tests branch July 19, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants