Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid augmenting subarrays post-ES2016 #351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chjj
Copy link
Contributor

@chjj chjj commented Feb 4, 2024

Not sure whether this helps performance, but subarrays only need augmenting pre-ES2016. Might be good to avoid it if we can.

The code detects whether TypedArray#subarray calls the child class' constructor (a la ES2016) at the end of the file -- once the Buffer prototype is completely setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant