Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ferdi server to hosted services #49

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

SpecialAro
Copy link
Member

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Add Ferdi API Server to hosted services.

Motivation and Context

This fixes the following open issue #38.

Screenshots

image

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Add Ferdi API to Ferdium hosted services.

@vraravam
Copy link
Contributor

I see a lot of hits in Login.js, AccountDashboard.js and other files if I search for LIVE_FRANZ_API - don't they also need to accommodate the new constant?

@SpecialAro
Copy link
Member Author

Maybe. I can try to give it a look for the rest, although I'm not entirely sure they will be needed.

I tested the current code with Account Creation and Login to the ferdi API and it worked, at least.

@vraravam
Copy link
Contributor

please also ensure that all paths of code that use the apiBase.js are also tested. for eg, Help > Import/Export Configuration Data opens the browser in specific url

SettingsNavigation.js and TeamDashboard.js also have a call to LIVE_FERDI_API but it handles the feature "Teams" that I think neither Ferdi or Ferdium provide.
Removes comment on apiBase.ts because I tested and the Terms where redirecting fine on the Help Menu
src/api/apiBase.ts Show resolved Hide resolved
@vraravam vraravam merged commit c7c774c into ferdium:develop Apr 27, 2022
@SpecialAro SpecialAro deleted the hosted-servers branch April 27, 2022 14:26
typoworx-de pushed a commit to typoworx-de/ferdium-app that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants