Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable todos feature by default #355

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

cino
Copy link
Contributor

@cino cino commented Jun 24, 2022

Description of Change

Disable the TODO feature by default and let the user enable it themselves.

Motivation and Context

  • Valid feedback from Reddit
  • Open discussion about it on Discord :)

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

  • Disable the TODO feature by default and let the user enable it themselves.

Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Didn't preview locally but logic seems correct and easy.

@vraravam
Copy link
Contributor

Tested locally - its working as expected.

@SpecialAro SpecialAro merged commit dae00ac into ferdium:develop Jun 24, 2022
@cino cino deleted the initially-disable-todos branch June 24, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants