Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a less-obstrusive progress bar on top of the Ferdium window #285

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jun 17, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Added a new progress-bar based on https://www.npmjs.com/package/react-topbar-progress-indicator which is less obstrusive.

Motivation and Context

Fixes #239 in a hopefully better manner

Screenshots

Sorry, don't know how to capture gif in macos. Here's a screenshot
screenshot

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam
Copy link
Contributor Author

Merging this PR since I don't want to miss the nightly.

@vraravam vraravam merged commit 9b052c5 into ferdium:develop Jun 17, 2022
@vraravam vraravam deleted the progress-bar branch June 17, 2022 17:23
@marco-calautti
Copy link

Would you also consider simply adding an option to disable the progress bar altogether? I do not think it is very informative in most cases, since it does not show the overall page loading progress, but it seems to show the loading of different resources, which essentially results in the bar flashing, quickly going from 0% to 100%, for each resource.

@vraravam
Copy link
Contributor Author

vraravam commented Jul 1, 2022

@marco-calautti - such a feature (to enable/disable the progress bar) at a per-service level is already implemented and has been in use for quite a few nightlies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Progress Indicator for page loading and downloads
2 participants