Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to fix warnings on npm i #282

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

SpecialAro
Copy link
Member

@SpecialAro SpecialAro commented Jun 16, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Update dependencies to fix warnings on npm i

Motivation and Context

This is related to #279
Now, only 10 warnings remaining.
image

The remaining warnings are mostly related with the gulp package (which hasn't been upgraded in three years) and the @adonisjs dependencies (mainly ace).

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Update dependencies to fix most warnings on npm i

@SpecialAro SpecialAro requested review from vraravam and a team June 16, 2022 21:58
@SpecialAro SpecialAro self-assigned this Jun 16, 2022
@SpecialAro SpecialAro changed the title Update dependencies to fix most warnings on npm i Update dependencies to fix warnings on npm i Jun 16, 2022
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vraravam vraravam merged commit 19c46da into ferdium:develop Jun 17, 2022
@SpecialAro SpecialAro deleted the update-deps branch June 20, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants