Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integration with sentry (fixes #233) #234

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jun 11, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Removed integration with sentry since it was pointing to the Ferdi API key. Fixes #233

Motivation and Context

Sentry a paid service, and while we are still waiting for the windows and macos dev licenses / signing keys, a paid sentry license doesn't make sense.

Note: If we need to resurrect this at a later point in time, we can simply revert this commit and replace the token for Ferdium.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team June 11, 2022 22:30
@vraravam vraravam self-assigned this Jun 11, 2022
Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ferdium uses same sentry instance as getferdi/ferdi
2 participants