Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add color picker component for accent color setting #228

Merged
merged 5 commits into from
Jun 11, 2022

Conversation

SpecialAro
Copy link
Member

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Feature: Add color picker component for accent color setting

Motivation and Context

My OCD lead me to add a color picker that automatically updates the input field of the CSS code so that people can just slide the picker and chose the color, while maintaining the ability of putting a CSS color code. Also, added a "Apply" button for this setting so that the color is updated when clicked.

There is probably some cleaning to do on all the files, but given it is my first time doing something of react specific stuff I'll need some guidance and assistance on that. Please review them and suggest things 🙏

Screenshots

Before image After image

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Feature: Add color picker component for accent color setting

@SpecialAro SpecialAro requested a review from a team June 10, 2022 15:14
src/components/ui/ColorPickerInput.js Outdated Show resolved Hide resolved
@SpecialAro SpecialAro merged commit 2dcb641 into ferdium:develop Jun 11, 2022
@SpecialAro SpecialAro deleted the color-picker branch June 11, 2022 21:48
vraravam added a commit that referenced this pull request Jun 11, 2022
Co-authored-by: Vijay A <vraravam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants