-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add ability to navigate recipe with mouse buttons #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this since I dont use a mouse. but, the changes look correct.
I've tested locally and seems to be fine 😄 I'll wait for the builds to pass so we can merge. |
Ah, so it's a |
Yep! I was doing the same for some days now 😭 Took a lot of reading to achieve this (which was pretty simple in fact). For reference, electron/electron#17134 this is currently still open and I confirmed that 'app-command' doesn't trigger mouse events properly. |
@SpecialAro Thank you! I was missing this badly! I really appreciate it! |
@eitanprezes 😅 me too! Thank you for your feedback. Did you manage to test it yet? The latest nightly (57) is failing for quite some people and we are still looking why. |
Just tested it on multiple services, including gmail, outlook365, tutanota, protonmail, github, and so far works like a charm. |
nightly.58 should have fixed the blank screen bug now |
@kris7t Confirmed, this is fixed! |
Pre-flight Checklist
Description of Change
Feature: Add ability to navigate recipe with mouse buttons
Motivation and Context
This feature adds the ability to navigate recipes with mouse buttons. It fixes #45.
Checklist
npm run prepare-code
)npm test
passesRelease Notes
Feature: Add ability to navigate recipe with mouse buttons