Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add ability to navigate recipe with mouse buttons #223

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

SpecialAro
Copy link
Member

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Feature: Add ability to navigate recipe with mouse buttons

Motivation and Context

This feature adds the ability to navigate recipes with mouse buttons. It fixes #45.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Feature: Add ability to navigate recipe with mouse buttons

@SpecialAro SpecialAro requested a review from a team June 9, 2022 09:56
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this since I dont use a mouse. but, the changes look correct.

@SpecialAro
Copy link
Member Author

SpecialAro commented Jun 9, 2022

I haven't tested this since I dont use a mouse. but, the changes look correct.

I've tested locally and seems to be fine 😄 I'll wait for the builds to pass so we can merge.

@kris7t
Copy link
Member

kris7t commented Jun 9, 2022

Ah, so it's a mouseup event and not an auxclick event 🙂 no wonder why I didn't manage to fix this, I was trying to hook the wrong event

@SpecialAro
Copy link
Member Author

Ah, so it's a mouseup event and not an auxclick event 🙂 no wonder why I didn't manage to fix this, I was trying to hook the wrong event

Yep! I was doing the same for some days now 😭 Took a lot of reading to achieve this (which was pretty simple in fact). For reference, electron/electron#17134 this is currently still open and I confirmed that 'app-command' doesn't trigger mouse events properly.

@SpecialAro SpecialAro merged commit 6cbb438 into ferdium:develop Jun 9, 2022
@SpecialAro SpecialAro deleted the fix-45 branch June 9, 2022 13:47
@pepper3k
Copy link

@SpecialAro Thank you! I was missing this badly!

I really appreciate it!

@SpecialAro
Copy link
Member Author

@eitanprezes 😅 me too! Thank you for your feedback. Did you manage to test it yet? The latest nightly (57) is failing for quite some people and we are still looking why.

@pepper3k
Copy link

Just tested it on multiple services, including gmail, outlook365, tutanota, protonmail, github, and so far works like a charm.
Win7x64 - nightly-56
nightly-57 was giving me a blank screen too :(
Thanks again!

@kris7t
Copy link
Member

kris7t commented Jun 12, 2022

nightly.58 should have fixed the blank screen bug now

@pepper3k
Copy link

@kris7t Confirmed, this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: direct mouse buttons 4 & 5 to the web app
4 participants