Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Input box to slider on Grayscale Dim level setting #207

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

SpecialAro
Copy link
Member

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Change Input box to slider on Grayscale Dim level setting

Motivation and Context

The input box on settings to change the Grayscale Dim level was ugly. Saw that it was possible to use a Slider instead, so raising this PR to change it.

Screenshots

Before: image After: image

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Change Input box to slider on Grayscale Dim level setting

@SpecialAro SpecialAro requested a review from a team June 1, 2022 17:05
@vraravam vraravam merged commit 22485b7 into ferdium:develop Jun 1, 2022
@SpecialAro SpecialAro deleted the Dim-slider branch June 1, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants