Change the termBase for accountless mode #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Description of Change
Change the termBase for accountless mode
Motivation and Context
This fixes #152.
Although this provides an easy fix for the problem, do we want to keep it this way? This implementation forwards the Privacy Statement and the Terms of Service on the Help menu to the Ferdium API if no server is selected (accountless mode). This may be something we don't want to do given the fact that https://api.ferdium.org/terms.html has some terms related with Accounts and https://api.ferdium.org/privacy.html to data collection - which is not true when he have an accountless option.
Maybe providing a different file (maybe a local one) for terms and privacy when in accountless mode should be a better solution. Regardless, I'll keep this PR open so the discussion can happen.
Checklist
npm run prepare-code
)npm test
passes