Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the termBase for accountless mode #160

Merged
merged 2 commits into from
May 16, 2022

Conversation

SpecialAro
Copy link
Member

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Change the termBase for accountless mode

Motivation and Context

This fixes #152.
Although this provides an easy fix for the problem, do we want to keep it this way? This implementation forwards the Privacy Statement and the Terms of Service on the Help menu to the Ferdium API if no server is selected (accountless mode). This may be something we don't want to do given the fact that https://api.ferdium.org/terms.html has some terms related with Accounts and https://api.ferdium.org/privacy.html to data collection - which is not true when he have an accountless option.

Maybe providing a different file (maybe a local one) for terms and privacy when in accountless mode should be a better solution. Regardless, I'll keep this PR open so the discussion can happen.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

src/api/apiBase.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner. Thanks for the suggestion @nathanaelhoun

@vraravam vraravam merged commit 8ba6165 into ferdium:develop May 16, 2022
@SpecialAro SpecialAro deleted the Fix-152 branch May 16, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ferdium Help menu has broken options
3 participants