Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where the replacement of double-slash was over-aggressive #151

Merged
merged 1 commit into from
May 15, 2022

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented May 15, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

The previous fix for handling trailing / in the urls was overly aggressive in removing double-/ - due to which if an embedded url in the query string was present, that would also go from http://<> to http:/<>. This PR fixes that and also adds a unit test for the same to avoid regression.
Fixes #141

Motivation and Context

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam self-assigned this May 15, 2022
@vraravam vraravam merged commit f4fd7dc into ferdium:develop May 15, 2022
@vraravam vraravam deleted the fix-141 branch May 15, 2022 03:36
@nathanaelhoun nathanaelhoun removed their request for review May 15, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Links in Gmail Service Return Invalid URL
1 participant